HappenLee commented on code in PR #51392:
URL: https://github.com/apache/doris/pull/51392#discussion_r2117961729
##########
be/src/vec/functions/function_regexp.cpp:
##########
@@ -501,6 +502,84 @@ struct RegexpExtractAllImpl {
}
};
+struct RegexpCountImpl {
+ static constexpr auto name = "regexp_count";
+
+ static void execute_impl(FunctionContext* context, ColumnPtr
argument_columns[],
Review Comment:
maybe we only need impl template<bool const>execute_impl.
can remove the unless code func `execute_impl_const_args`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
