timey13 commented on code in PR #45:
URL:
https://github.com/apache/doris-spark-connector/pull/45#discussion_r934666724
##########
spark-doris-connector/build.sh:
##########
@@ -45,6 +45,17 @@ usage() {
exit 1
}
+# we use GNU enhanced version getopt command here for long option names,
rather than the original version
+# determine the version of the getopt command before using
+getopt -T > /dev/null
+if [ $? -ne 4 ]; then
+ echo "
+ The GNU version of getopt command is required.
+ On Mac OS, you can use Homebrew to install gnu-getopt: brew install
gnu-getopt, then set gnu-getopt as default getopt. Refernence:
https://stackoverflow.com/questions/12152077/how-can-i-make-bash-deal-with-long-param-using-getopt-command-in-mac
+ "
+ exit 1
+fi
+
Review Comment:
@caoliang-web I guess we use different homebrew version or Mac OS version. I
reproduce this problem on another Mac, the gnu-getopt path is
"/opt/homebrew/opt/gnu-getopt/bin", which is different with the one that I
tested right. therefore, I update the commit again, please review it.
Major update point: use "brew --prefix gnu-getopt" to get the execute path
of installed GNU version getopt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
