yiguolei commented on code in PR #50817:
URL: https://github.com/apache/doris/pull/50817#discussion_r2115413366


##########
be/src/runtime/exec_env.h:
##########
@@ -234,7 +233,7 @@ class ExecEnv {
     ThreadPool* non_block_close_thread_pool();
     ThreadPool* s3_file_system_thread_pool() { return 
_s3_file_system_thread_pool.get(); }
 
-    Status init_pipeline_task_scheduler();
+    Status init_dummy_workload_group();

Review Comment:
   这个方法,不需要是public的,直接private的就可以,另外,private的需要 下划线开头



##########
be/src/runtime/exec_env.h:
##########
@@ -367,6 +368,8 @@ class ExecEnv {
     void set_stream_mgr(vectorized::VDataStreamMgr* vstream_mgr) { 
_vstream_mgr = vstream_mgr; }
     void clear_stream_mgr();
 
+    void init_runtime_filter_timer_queue();

Review Comment:
   这个方法也是



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to