xinyiZzz commented on code in PR #51265:
URL: https://github.com/apache/doris/pull/51265#discussion_r2108459559


##########
be/src/util/arrow/utils.h:
##########
@@ -55,6 +55,17 @@ namespace doris {
         }                                     \
     } while (false)
 
+#define RETURN_ARROW_STATUS_IF_CATCH_EXCEPTION(stmt)                           
                  \
+    do {                                                                       
                  \
+        try {                                                                  
                  \
+            arrow::Status _status_ = (stmt);                                   
                  \
+            return _status_;                                                   
                  \
+        } catch (const doris::Exception& e) {                                  
                  \
+            ARROW_RETURN_NOT_OK(to_arrow_status(Status::Error<false>(e.code(), 
e.to_string()))); \

Review Comment:
   这里会直接return,因为 ARROW_RETURN_NOT_OK 中 to_arrow_status 返回的永远是 error status
   但编译器无法识别,会编译报错,所以加了个 return arrow::Status::OK();



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to