yiguolei commented on code in PR #51271:
URL: https://github.com/apache/doris/pull/51271#discussion_r2108081710
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -1231,4 +1232,50 @@ StoragePageCache::CacheKey
Segment::get_segment_footer_cache_key() const {
_file_reader->size() - 12);
}
+std::map<uint32_t, Segment::ZoneMapInfo> Segment::get_zone_maps() const {
+ if (!config::enable_rowset_zone_map_cache ||
config::cache_zone_map_max_columns_count == 0) {
+ return {};
+ }
+
+ auto footer_pb = _footer_pb.lock();
+ if (!footer_pb) {
+ return {};
Review Comment:
如果没lock 住，这里应该去磁盘里读取一下吧？
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -1231,4 +1232,50 @@ StoragePageCache::CacheKey
Segment::get_segment_footer_cache_key() const {
_file_reader->size() - 12);
}
+std::map<uint32_t, Segment::ZoneMapInfo> Segment::get_zone_maps() const {
+ if (!config::enable_rowset_zone_map_cache ||
config::cache_zone_map_max_columns_count == 0) {
+ return {};
+ }
+
+ auto footer_pb = _footer_pb.lock();
+ if (!footer_pb) {
+ return {};
Review Comment:
如果没lock 住，这里应该去磁盘里读取一下吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
