morningman commented on code in PR #51229:
URL: https://github.com/apache/doris/pull/51229#discussion_r2107420347
##########
fe/fe-core/src/main/java/org/apache/doris/fsv2/obj/S3ObjStorage.java:
##########
@@ -101,103 +110,12 @@ public S3Client getClient() throws UserException {
endpointStr = "http://"; + endpointStr;
}
URI endpoint = URI.create(endpointStr);
- CloudCredential credential = new CloudCredential();
- credential.setAccessKey(s3Properties.getAccessKey());
- credential.setSecretKey(s3Properties.getSecretKey());
- if (StringUtils.isNotBlank(s3Properties.getSessionToken())) {
- credential.setSessionToken(s3Properties.getSessionToken());
- }
- client = S3Util.buildS3Client(endpoint, s3Properties.getRegion(),
credential, isUsePathStyle);
+ client = S3Util.buildS3Client(endpoint, s3Properties.getRegion(),
+ isUsePathStyle, s3Properties.getAwsCredentialsProvider());
}
return client;
}
- public Status globList(String remotePath, List<RemoteFile> result, boolean
fileNameOnly) {
- long roundCnt = 0;
- long elementCnt = 0;
- long matchCnt = 0;
- long startTime = System.nanoTime();
- try {
- S3URI uri = S3URI.create(remotePath, isUsePathStyle,
forceParsingByStandardUri);
- String bucket = uri.getBucket();
- String globPath = uri.getKey(); // eg: path/to/*.csv
- if (LOG.isDebugEnabled()) {
Review Comment:
`if (LOG.isDebugEnabled())` is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
