morningman commented on code in PR #50675:
URL: https://github.com/apache/doris/pull/50675#discussion_r2099541666
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1183,19 +1185,39 @@ Status OrcReader::set_fill_columns(
tiny_stripe_ranges.emplace_back(strip_start_offset,
strip_end_offset);
}
if (all_tiny_stripes && number_of_stripes > 0) {
- std::vector<io::PrefetchRange> prefetch_merge_ranges =
-
io::PrefetchRange::merge_adjacent_seq_ranges(tiny_stripe_ranges,
-
_orc_max_merge_distance_bytes,
-
_orc_once_max_read_bytes);
- auto range_finder =
-
std::make_shared<io::LinearProbeRangeFinder>(std::move(prefetch_merge_ranges));
-
- auto* orc_input_stream_ptr =
static_cast<ORCFileInputStream*>(_reader->getStream());
- orc_input_stream_ptr->set_all_tiny_stripes();
- auto& orc_file_reader = orc_input_stream_ptr->get_file_reader();
- auto orc_inner_reader = orc_input_stream_ptr->get_inner_reader();
- orc_file_reader =
std::make_shared<io::RangeCacheFileReader>(_profile, orc_inner_reader,
-
range_finder);
+ //The first stripe in the read file is selected to calculate an
approximate
+ // read amplification factor using the tiny stripe optimization.
+ std::vector<bool> selectedColumns;
Review Comment:
```suggestion
std::vector<bool> selected_columns;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
