morningman commented on code in PR #51190:
URL: https://github.com/apache/doris/pull/51190#discussion_r2105683188


##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -530,6 +530,9 @@ struct TIcebergMetadataParams {
   2: optional string catalog
   3: optional string database
   4: optional string table
+  5: optional string serialized_table
+  6: optional string serialized_split
+  7: optional map<string, string> hadoop_props

Review Comment:
   Think twice, what if we need to connect to s3?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to