wangshuo128 commented on code in PR #11299: URL: https://github.com/apache/doris/pull/11299#discussion_r932980621
########## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/logical/PushDownPredicateTest.java: ########## @@ -242,6 +243,7 @@ public void pushDownPredicateIntoScanTest4() { } private Memo rewrite(Plan plan) { - return PlanRewriter.topDownRewriteMemo(plan, new ConnectContext(), new PushPredicateThroughJoin()); + Plan normalizedPlan = PlanRewriter.topDownRewrite(plan, new ConnectContext(), new NormalizeExpressions()); Review Comment: Ok, never mind. I was thinking to avoid copying in and copying out of `memo` multiple times. Let's refactor this when we have more similar cases in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org