zhannngchen commented on code in PR #11289: URL: https://github.com/apache/doris/pull/11289#discussion_r932206948
########## be/src/olap/tablet_meta.cpp: ########## @@ -734,6 +736,46 @@ Status TabletMeta::set_partition_id(int64_t partition_id) { return Status::OK(); } +// update dst rowset delete bitmap for unique key merge on write table. +// we take a delete bitmap's snapshot of origin rowset at the beginning Review Comment: 改完后又看了一遍,有点啰嗦,精简了一下😂 We take a delete bitmap's snapshot of origin rowset at the beginning of compaction, some keys of origin rowsets might be deleted during compaction, but exist in dest rowset. so we need to update the bitmap of dest rowset after compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org