morrySnow commented on code in PR #50852:
URL: https://github.com/apache/doris/pull/50852#discussion_r2086235073
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushDownAggThroughJoin.java:
##########
@@ -92,7 +93,7 @@ public List<Rule> buildRules() {
logicalAggregate(logicalProject(innerLogicalJoin()))
.when(agg -> agg.child().isAllSlots())
.when(agg ->
agg.child().child().getOtherJoinConjuncts().isEmpty())
- .whenNot(agg ->
agg.child().children().stream().anyMatch(p -> p instanceof LogicalAggregate))
+ .whenNot(agg ->
agg.child().child().children().stream().anyMatch(p -> p instanceof
LogicalAggregate))
Review Comment:
use when on exact node to avoid using in wrong place. for example
```
logicalAggregate(logicalProject(innerLogicalJoin()).when(LogicalProject::isAllSlots))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
