starocean999 commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083744923
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -6116,14 +6116,15 @@ public LogicalPlan
visitShowConvertLsc(ShowConvertLscContext ctx) {
@Override
public LogicalPlan visitKillQuery(KillQueryContext ctx) {
Review Comment:
based on old planner, if specify QUERY KEYWORD, it always means to kill
query, and the query id is whatever INTEGER_VALUE or STRING_LITERAL. Looks like
the behavior is changed in this pr?
```
kill_stmt ::=
KW_KILL INTEGER_LITERAL:value
{:
RESULT = new KillStmt(true, value.intValue());
:}
| KW_KILL KW_CONNECTION INTEGER_LITERAL:value
{:
RESULT = new KillStmt(true, value.intValue());
:}
| KW_KILL KW_QUERY INTEGER_LITERAL:value
{:
RESULT = new KillStmt(false, value.intValue());
:}
| KW_KILL KW_QUERY STRING_LITERAL:value
{:
RESULT = new KillStmt(value);
:}
;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
