gavinchou commented on code in PR #50173:
URL: https://github.com/apache/doris/pull/50173#discussion_r2083081533
##########
cloud/src/common/config.h:
##########
@@ -281,4 +282,6 @@ CONF_Strings(recycler_storage_vault_white_list, "");
// Trace = 6
CONF_Int32(aws_log_level, "2");
+CONF_mString(delete_bitmap_lock_version_white_list, "");
Review Comment:
naming should contain which version is this whitelist for
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1811,14 +1814,9 @@ static bool check_delete_bitmap_lock(MetaServiceCode&
code, std::string& msg, st
}
return true;
}
-static bool use_new_version_random() {
- std::mt19937 gen {std::random_device {}()};
- auto p = 0.5;
- std::bernoulli_distribution inject_fault {p};
- if (inject_fault(gen)) {
- return true;
- }
- return false;
+
+void MetaServiceImpl::get_version(std::string& use_version, std::string&
instance_id) {
Review Comment:
use a specific name like get_delete_bitmap_lock_version,
get_versionb is too generous
##########
cloud/src/common/config.h:
##########
@@ -264,6 +264,7 @@ CONF_Bool(enable_loopback_address_for_ms, "false");
// delete_bitmap_lock version config
CONF_mString(use_delete_bitmap_lock_version, "v1");
+CONF_mInt64(update_delete_bitmap_lock_white_list_interval_seconds, "10");
Review Comment:
this is redundant interval, we should detect whitelist change when we try to
get version,
once it is changed (we can store an original sting in DeleteBitmapWhitelist
for checking) update the whitelist map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
