englefly commented on code in PR #11209:
URL: https://github.com/apache/doris/pull/11209#discussion_r930933465
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -532,16 +537,52 @@ public List<Expression>
visitNamedExpressionSeq(NamedExpressionSeqContext namedC
* @return List of OrderKey
*/
@Override
- public List<OrderKey> visitQueryOrganization(QueryOrganizationContext ctx)
{
Review Comment:
Consider this function: `public LimitAndOffset
visitLimitClause(LimitClauseContext ctx)`
If we remove `LimitAndOffset`, we still need a container for 2 reasons.
1. the container wraps `limit` and `offset` as a return result. Maybe we
could use `Pair` instead of `LimitAndOffset`
2. the null container indicate that there is no limit clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
