yiguolei commented on code in PR #11131:
URL: https://github.com/apache/doris/pull/11131#discussion_r930668475
##########
be/src/olap/rowset/rowset.cpp:
##########
@@ -32,7 +32,7 @@ Rowset::Rowset(const TabletSchema* schema, const std::string&
tablet_path,
_is_cumulative = version.first != version.second;
}
// build schema from RowsetMeta.tablet_schema or Tablet.tablet_schema
- _schema = _rowset_meta->tablet_schema() != nullptr ?
_rowset_meta->tablet_schema() : schema;
+ _schema = _rowset_meta->tablet_schema() ?
_rowset_meta->tablet_schema().get() : schema;
Review Comment:
should also change _schema in rowset.h to TabletSchemaSPtr. There maybe
segment fault if we add clean logic in tablet schema cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
