yiguolei commented on code in PR #50549:
URL: https://github.com/apache/doris/pull/50549#discussion_r2077119191
##########
be/src/vec/common/pod_array.h:
##########
@@ -143,6 +146,32 @@ class PODArrayBase : private boost::noncopyable,
return byte_size(num_elements) + pad_right + pad_left;
}
+ // `tracking_and_check_memory` is called after alloc memory.
+ inline void tracking_and_check_memory(int64_t size) {
+ CONSUME_THREAD_MEM_TRACKER(size);
Review Comment:
这行应该放到check 成功之后consume，否则，这里consume了，然后底下throw exception
失败了，我们去释放的时候，感觉可能结果不对
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
