Copilot commented on code in PR #50392:
URL: https://github.com/apache/doris/pull/50392#discussion_r2073471766
##########
be/src/vec/functions/function_datetime_floor_ceil.cpp:
##########
@@ -264,7 +287,7 @@ class FunctionDateTimeFloorCeil : public IFunction {
res[i] = origin_date; \
auto ts2 = binary_cast<NativeType, DateValueType>(dates[i]); \
auto& ts1 = (DateValueType&)(res[i]); \
Review Comment:
[nitpick] The explicit template instantiation for time_round_two_args
improves compile-time optimization for constant input periods; consider adding
a brief inline comment to explain this design choice for maintainers.
```suggestion
auto& ts1 = (DateValueType&)(res[i]); \
// Explicit template instantiation for time_round_two_args
improves
// compile-time optimization for constant input periods.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
