jackwener commented on code in PR #11035:
URL: https://github.com/apache/doris/pull/11035#discussion_r929618914
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java:
##########
@@ -51,64 +51,64 @@ public class BindSlotReference implements
AnalysisRuleFactory {
@Override
public List<Rule> buildRules() {
return ImmutableList.of(
- RuleType.BINDING_PROJECT_SLOT.build(
- logicalProject().then(project -> {
- List<NamedExpression> boundSlots =
- bind(project.getProjects(), project.children(),
project);
- return new LogicalProject<>(flatBoundStar(boundSlots),
project.child());
- })
- ),
- RuleType.BINDING_FILTER_SLOT.build(
- logicalFilter().then(filter -> {
- Expression boundPredicates = bind(filter.getPredicates(),
filter.children(), filter);
- return new LogicalFilter<>(boundPredicates,
filter.child());
- })
- ),
- RuleType.BINDING_JOIN_SLOT.build(
- logicalJoin().then(join -> {
- Optional<Expression> cond = join.getCondition()
- .map(expr -> bind(expr, join.children(), join));
- return new LogicalJoin<>(join.getJoinType(), cond,
join.left(), join.right());
- })
- ),
- RuleType.BINDING_AGGREGATE_SLOT.build(
- logicalAggregate().then(agg -> {
- List<Expression> groupBy =
bind(agg.getGroupByExpressions(), agg.children(), agg);
- List<NamedExpression> output =
bind(agg.getOutputExpressions(), agg.children(), agg);
- return agg.withGroupByAndOutput(groupBy, output);
- })
- ),
- RuleType.BINDING_SORT_SLOT.build(
- logicalSort().then(sort -> {
- List<OrderKey> sortItemList = sort.getOrderKeys()
- .stream()
- .map(orderKey -> {
- Expression item = bind(orderKey.getExpr(),
sort.children(), sort);
- return new OrderKey(item, orderKey.isAsc(),
orderKey.isNullFirst());
- }).collect(Collectors.toList());
+ RuleType.BINDING_PROJECT_SLOT.build(
Review Comment:
Reduce the `code-style-change`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
