Kikyou1997 commented on code in PR #11179: URL: https://github.com/apache/doris/pull/11179#discussion_r929585624
########## fe/fe-core/src/main/java/org/apache/doris/nereids/util/Utils.java: ########## @@ -39,8 +39,49 @@ public static String quoteIfNeeded(String part) { } /** - * Fully qualified identifier name parts, i.e., concat qualifier and name into a list. Review Comment: I would note this next time, we didn't do as that is because I thought place related funciton together may be easy to read. ########## fe/fe-core/src/main/java/org/apache/doris/nereids/util/Utils.java: ########## @@ -39,8 +39,49 @@ public static String quoteIfNeeded(String part) { } /** - * Fully qualified identifier name parts, i.e., concat qualifier and name into a list. Review Comment: I would note this next time, I didn't do as that is because I thought place related funciton together may be easy to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org