compasses commented on code in PR #11144:
URL: https://github.com/apache/doris/pull/11144#discussion_r928937707


##########
be/src/olap/merger.cpp:
##########
@@ -41,8 +41,9 @@ Status Merger::merge_rowsets(TabletSharedPtr tablet, 
ReaderType reader_type,
     reader_params.reader_type = reader_type;
     reader_params.rs_readers = src_rowset_readers;
     reader_params.version = dst_rowset_writer->version();
-
     reader_params.tablet_schema = cur_tablet_schema;
+    reader_params.use_page_cache = false; // shouldn't use page cache

Review Comment:
   Yes, I see. but this field is not a new one, here just make sure it was set 
properly. BTW, If we have option for page cache switch, I think it's better to 
treat the option with top priority. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to