wangbo commented on code in PR #11175:
URL: https://github.com/apache/doris/pull/11175#discussion_r928786365
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -208,20 +229,36 @@ void
AggregationNode::_init_hash_method(std::vector<VExprContext*>& probe_exprs)
if (use_fixed_key) {
if (has_null) {
if (std::tuple_size<KeysNullMap<UInt64>>::value +
key_byte_size <= sizeof(UInt64)) {
- _agg_data.init(AggregatedDataVariants::Type::int64_keys,
has_null);
+ if (_is_streaming_preagg)
+
_agg_data.init(AggregatedDataVariants::Type::int64_keys, has_null);
+ else
+
_agg_data.init(AggregatedDataVariants::Type::int64_keys_phase2, has_null);
Review Comment:
if _is_streaming_preagg == false, this means current AggNode maybe the
second phase of a streaming agg, but also may be a first phase of BlockAgg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
