morningman commented on code in PR #50471:
URL: https://github.com/apache/doris/pull/50471#discussion_r2062886727
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/fileformat/OrcFileFormatProperties.java:
##########
@@ -36,11 +47,26 @@ public OrcFileFormatProperties() {
@Override
public void analyzeFileFormatProperties(Map<String, String>
formatProperties, boolean isRemoveOriginProperty)
throws AnalysisException {
+ // get compression type
+ // save compress type
+ if (formatProperties.containsKey(PROP_COMPRESS_TYPE)) {
Review Comment:
Need add UT
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/fileformat/ParquetFileFormatProperties.java:
##########
@@ -42,11 +68,47 @@ public ParquetFileFormatProperties() {
@Override
public void analyzeFileFormatProperties(Map<String, String>
formatProperties, boolean isRemoveOriginProperty)
throws AnalysisException {
+ // save compress type
+ if (formatProperties.containsKey(PROP_COMPRESS_TYPE)) {
Review Comment:
Need add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
