wangshuo128 commented on code in PR #10479:
URL: https://github.com/apache/doris/pull/10479#discussion_r927581617
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushPredicateThroughJoin.java:
##########
@@ -42,28 +42,29 @@
/**
* Push the predicate in the LogicalFilter or LogicalJoin to the join children.
- * For example:
- * select a.k1,b.k1 from a join b on a.k1 = b.k1 and a.k2 > 2 and b.k2 > 5
where a.k1 > 1 and b.k1 > 2
- * Logical plan tree:
- * project
- * |
- * filter (a.k1 > 1 and b.k1 > 2)
- * |
- * join (a.k1 = b.k1 and a.k2 > 2 and b.k2 > 5)
- * / \
- * scan scan
- * transformed:
- * project
- * |
- * join (a.k1 = b.k1)
- * / \
- * filter(a.k1 > 1 and a.k2 > 2 ) filter(b.k1 > 2 and b.k2 > 5)
- * | |
- * scan scan
* todo: Now, only support eq on condition for inner join, support other case
later
*/
public class PushPredicateThroughJoin extends OneRewriteRuleFactory {
-
+ /*
Review Comment:
Comments should be wrapped in HTML tag `<pre></pre>` to avoid indents
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
