xzj7019 commented on code in PR #49096:
URL: https://github.com/apache/doris/pull/49096#discussion_r2055600827
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildrenPropertiesRegulator.java:
##########
@@ -300,7 +301,24 @@ public List<List<PhysicalProperties>>
visitPhysicalHashJoin(
Optional<PhysicalProperties> updatedForLeft = Optional.empty();
Optional<PhysicalProperties> updatedForRight = Optional.empty();
- if (JoinUtils.couldColocateJoin(leftHashSpec, rightHashSpec,
hashJoin.getHashJoinConjuncts())) {
+ if (hashJoin.getDistributeHint() != null
Review Comment:
add comments here and not forget to add similar handling logic in adaptive
scenario in the future, besides the hint injected cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
