airborne12 commented on code in PR #50306:
URL: https://github.com/apache/doris/pull/50306#discussion_r2055192413
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -385,10 +395,10 @@ int32_t
TimeSeriesCumulativeCompactionPolicy::pick_input_rowsets(
}
})
- // Condition 5: level1 achieve compaction_time_threshold
- if (last_cumu != 0 && level1_rowsets.size() >= 2) {
- int64_t cumu_interval = now - last_cumu;
- if (cumu_interval > compaction_time_threshold * 10 * 1000) {
+ // Condition 5: level1 achieve compaction_time_threshold_seconds
+ if (level1_rowsets.size() >= 2) {
+ int64_t cumu_interval = now -
level1_rowsets.front()->rowset_meta()->creation_time();
Review Comment:
how we confirm the creation time for front rowset of level1_rowsets queue is
the right timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
