yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035081749
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##########
@@ -504,24 +498,26 @@ public void dropWorkloadGroup(String workloadGroupName,
boolean ifExists) throws
}
}
+ Pair<String, String> key = Pair.of(computeGroup, workloadGroupName);
writeLock();
try {
- if (!nameToWorkloadGroup.containsKey(workloadGroupName)) {
+ if (!nameToWorkloadGroup.containsKey(key)) {
if (ifExists) {
return;
}
- throw new DdlException("workload group " + workloadGroupName +
" does not exist");
+ throw new DdlException(
+ "can not find workload group " + workloadGroupName + "
in compute group " + computeGroup + ".");
}
- WorkloadGroup workloadGroup =
nameToWorkloadGroup.get(workloadGroupName);
+ WorkloadGroup workloadGroup = nameToWorkloadGroup.get(key);
long groupId = workloadGroup.getId();
idToWorkloadGroup.remove(groupId);
- nameToWorkloadGroup.remove(workloadGroupName);
+ nameToWorkloadGroup.remove(key);
idToQueryQueue.remove(groupId);
Env.getCurrentEnv().getEditLog().logDropWorkloadGroup(new
DropWorkloadGroupOperationLog(groupId));
} finally {
writeUnlock();
}
- LOG.info("Drop workload group success: {}", workloadGroupName);
+ LOG.info("Drop workload group success: {} for {}", workloadGroupName,
computeGroup);
Review Comment:
for compute group {} ， 写全了，否则别人看日志看不明白，只有看代码的才之后for 后面是compute group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
