dataroaring commented on code in PR #49953:
URL: https://github.com/apache/doris/pull/49953#discussion_r2036725066
##########
be/src/olap/tablet.cpp:
##########
@@ -1770,12 +1770,15 @@ Status Tablet::prepare_compaction_and_calculate_permits(
// return OK if OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION, so that
we don't need to
// print too much useless logs.
// And because we set permits to 0, so even if we return OK here,
nothing will be done.
- LOG_INFO(
- "cumulative compaction meet delete rowset, increase cumu
point without other "
- "operation.")
- .tag("tablet id:", tablet->tablet_id())
- .tag("after cumulative compaction, cumu point:",
- tablet->cumulative_layer_point());
+ if (res.msg() == "_last_delete_version.first not equal to -1") {
Review Comment:
Too tricky. We should not depend on an error msg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
