Copilot commented on code in PR #49573:
URL: https://github.com/apache/doris/pull/49573#discussion_r2020540644
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalPlan.java:
##########
@@ -77,15 +79,23 @@ public <T extends AbstractPhysicalPlan>
AbstractPhysicalPlan copyStatsAndGroupId
return newPlan;
}
- public List<RuntimeFilter> getAppliedRuntimeFilters() {
+ public List<org.apache.doris.nereids.trees.plans.physical.RuntimeFilter>
getAppliedRuntimeFilters() {
return appliedRuntimeFilters;
}
- public void addAppliedRuntimeFilter(RuntimeFilter filter) {
+ public void
addAppliedRuntimeFilter(org.apache.doris.nereids.trees.plans.physical.RuntimeFilter
filter) {
appliedRuntimeFilters.add(filter);
}
- public void removeAppliedRuntimeFilter(RuntimeFilter filter) {
+ public void addRuntimeFilterV2(RuntimeFilterV2 filter) {
Review Comment:
There is no corresponding removal method for runtimeFiltersV2, which makes
the API asymmetric compared to appliedRuntimeFilters. Consider adding a
removeRuntimeFilterV2 method to ensure consistent management of both runtime
filter types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
