yiguolei commented on code in PR #49281:
URL: https://github.com/apache/doris/pull/49281#discussion_r2005371420
##########
be/src/pipeline/dependency.cpp:
##########
@@ -68,32 +68,42 @@ void Dependency::set_ready() {
local_block_task.swap(_blocked_task);
}
for (auto* task : local_block_task) {
- task->wake_up();
+ {
+ std::unique_lock<std::mutex> lc(_task_lock);
+ DCHECK_EQ(task->_blocked_dep, this)
+ << "dep : " << debug_string(0) << "task: " <<
debug_string();
+ task->_blocked_dep = nullptr;
+
THROW_IF_ERROR(task->_state_transition(PipelineTask::State::RUNNABLE));
+ }
+ task->wake_up(this);
}
}
-Dependency* Dependency::is_blocked_by(PipelineTask* task) {
+bool Dependency::is_blocked_by(PipelineTask* task) {
std::unique_lock<std::mutex> lc(_task_lock);
auto ready = _ready.load();
if (!ready && task) {
_add_block_task(task);
+ DCHECK_EQ(task->_blocked_dep, nullptr) << "task: " <<
task->debug_string();
+ task->_blocked_dep = this;
+ start_watcher();
+ THROW_IF_ERROR(task->_state_transition(PipelineTask::State::BLOCKED));
}
- return ready ? nullptr : this;
+ return !ready;
}
-Dependency* QueryGlobalDependency::is_blocked_by(PipelineTask* task) {
+bool QueryGlobalDependency::is_blocked_by(PipelineTask* task) {
if (task && task->wake_up_early()) {
Review Comment:
为啥这里还要判断wakeup early？？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
