This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 6430ff365db [Bug](partition) should not do reset for the
partition_sorts (#49148)
6430ff365db is described below
commit 6430ff365dbb86e634e2aefe07584c8a6fc0fbb2
Author: zhangstar333 <[email protected]>
AuthorDate: Tue Mar 18 18:03:29 2025 +0800
[Bug](partition) should not do reset for the partition_sorts (#49148)
### What problem does this PR solve?
Problem Summary:
the partition_sorts is unique_ptr，could release after destroy.
and when some extreme case like cancel, if source reset the sorter
early, the sink operator will coredump still use it.
---
be/src/pipeline/exec/partition_sort_source_operator.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/be/src/pipeline/exec/partition_sort_source_operator.cpp
b/be/src/pipeline/exec/partition_sort_source_operator.cpp
index 7c89b6ba423..b6c5327144c 100644
--- a/be/src/pipeline/exec/partition_sort_source_operator.cpp
+++ b/be/src/pipeline/exec/partition_sort_source_operator.cpp
@@ -104,7 +104,6 @@ Status
PartitionSortSourceOperatorX::get_sorted_block(RuntimeState* state,
}
if (current_eos) {
// current sort have eos, so get next idx
-
local_state._shared_state->partition_sorts[local_state._sort_idx].reset(nullptr);
local_state._sort_idx++;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
