Copilot commented on code in PR #48830:
URL: https://github.com/apache/doris/pull/48830#discussion_r2026652144
##########
fe/fe-core/src/main/java/org/apache/doris/job/task/Task.java:
##########
@@ -58,15 +58,16 @@ public interface Task {
* This method is called when the task executes successfully.
* Implementations can use this method to handle successful execution
scenarios.
*/
- void onSuccess() throws JobException;
+ boolean onSuccess() throws JobException;
Review Comment:
The method signature now returns a boolean, yet the corresponding JavaDoc
does not clarify the semantics of the return value. Please update the
documentation to reflect what true or false indicates.
##########
fe/fe-core/src/main/java/org/apache/doris/job/task/Task.java:
##########
@@ -44,7 +44,7 @@ public interface Task {
* This method is called when the task fails to execute successfully.
* Implementations can use this method to handle any failure scenarios.
*/
- void onFail() throws JobException;
+ boolean onFail() throws JobException;
Review Comment:
The method signature has been updated to return a boolean, but the JavaDoc
comment did not document what the return value represents. Consider updating
the comment to explain the meaning of true/false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
