qzsee commented on code in PR #49658:
URL: https://github.com/apache/doris/pull/49658#discussion_r2022097927
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##########
@@ -349,6 +357,15 @@ public void update(List<Pair<String, String>> properties,
boolean isReplay) thro
} catch (NumberFormatException e) {
throw new DdlException(PROP_USER_INSERT_TIMEOUT + " is not
number");
}
+ } else if (keyArr[0].equalsIgnoreCase(PROP_DEFAULT_INIT_CATALOG)) {
+ if (keyArr.length != 1) {
+ throw new DdlException(PROP_DEFAULT_INIT_CATALOG + "
format error");
+ }
+ CatalogIf catalog =
Env.getCurrentEnv().getCatalogMgr().getCatalog(value);
+ if (catalog == null) {
Review Comment:
Consider `getCatalogOrAnalysisException` method
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/CommonUserProperties.java:
##########
@@ -66,6 +67,9 @@ public class CommonUserProperties implements Writable,
GsonPostProcessable {
@SerializedName(value = "it", alternate = {"insertTimeout"})
private int insertTimeout = -1;
+ @SerializedName(value = "ic")
Review Comment:
Whether the `alternate` is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
