luwei16 commented on code in PR #47282:
URL: https://github.com/apache/doris/pull/47282#discussion_r1959557421
##########
be/src/cloud/cloud_cumulative_compaction_policy.cpp:
##########
@@ -209,10 +209,9 @@ int64_t
CloudSizeBasedCumulativeCompactionPolicy::new_cumulative_point(
config::compaction_promotion_version_count;
// if rowsets have delete version, move to the last directly.
// if rowsets have no delete version, check output_rowset total disk size
satisfies promotion size.
- return output_rowset->start_version() == last_cumulative_point &&
- (last_delete_version.first != -1 ||
- output_rowset->total_disk_size() >=
cloud_promotion_size(tablet) ||
- satisfy_promotion_version)
+ return (last_delete_version.first != -1 ||
Review Comment:
This issue is better tested through unit tests; add some unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
