cambyzju commented on code in PR #10781: URL: https://github.com/apache/doris/pull/10781#discussion_r922110741
########## be/src/vec/functions/array/function_array_except.cpp: ########## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/functions/array/function_array_binary.h" +#include "vec/functions/array/function_array_set.h" + +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +struct NameArrayExcept { + static constexpr auto name = "array_except"; +}; + +template <typename Set, typename Element> +struct ExceptAction { + // True if set has null element + bool null_flag = false; + // True if result_set has null element + bool result_null_flag = false; + // True if it should apply the left array first. + static constexpr auto apply_left_first = false; + + // Handle Null element. + // Return ture means this null element should put into result column. Review Comment: ```suggestion // Return true means this null element should put into result column. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
