amorynan commented on code in PR #49452:
URL: https://github.com/apache/doris/pull/49452#discussion_r2013266131


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java:
##########
@@ -196,7 +197,10 @@ public static void checkForTypeLengthChange(Type src, Type 
dst) throws DdlExcept
     // return true if the checkType and other are both char-type otherwise 
return false,
     // which used in checkSupportSchemaChangeForComplexType
     private static boolean checkSupportSchemaChangeForCharType(Type checkType, 
Type other) throws DdlException {
-        if (checkType.isStringType() && other.isStringType()) {
+        if (checkType.getPrimitiveType() == PrimitiveType.VARCHAR

Review Comment:
   please add FE UT in 
fe/fe-core/src/test/java/org/apache/doris/alter/SchemaChangeHandlerTest.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to