freemandealer commented on code in PR #49050:
URL: https://github.com/apache/doris/pull/49050#discussion_r2011467082
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java:
##########
@@ -542,9 +542,6 @@ private Map<Long, List<Tablet>>
warmUpNewClusterByTable(long jobId, String dstCl
List<Partition> warmUpPartitions = new ArrayList<>();
for (Partition partition : partitions) {
Long partitionSize = partition.getDataSize(true);
- if ((warmUpTotalFileCache + partitionSize) > totalFileCache) {
Review Comment:
that is why the problem occurs.
simply move it to 549 will skip all necessary jobs below and make this job
not only useless but also risky.
a better way, if we want to improve this, is to skip large one and cache
little one, since the original problem is cache space is not utilized fully
when doing warm up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
