yiguolei commented on code in PR #10355: URL: https://github.com/apache/doris/pull/10355#discussion_r919725533
########## be/src/vec/exec/volap_scan_node.cpp: ########## @@ -973,29 +1037,31 @@ bool VOlapScanNode::is_key_column(const std::string& key_name) { } void VOlapScanNode::remove_pushed_conjuncts(RuntimeState* state) { - if (_pushed_conjuncts_index.empty()) { + if (_pushed_conjuncts_index.empty() && _pushed_func_conjuncts_index.empty()) { return; } // dispose direct conjunct first std::vector<ExprContext*> new_conjunct_ctxs; for (int i = 0; i < _direct_conjunct_size; ++i) { - if (std::find(_pushed_conjuncts_index.cbegin(), _pushed_conjuncts_index.cend(), i) == - _pushed_conjuncts_index.cend()) { - new_conjunct_ctxs.emplace_back(_conjunct_ctxs[i]); + if (!_pushed_conjuncts_index.empty() && _pushed_conjuncts_index.count(i)) { Review Comment: In vectorized engine, it is _vconjuncts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org