wary commented on code in PR #285:
URL:
https://github.com/apache/doris-spark-connector/pull/285#discussion_r2009509738
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/config/DorisConfig.java:
##########
@@ -86,8 +86,10 @@ private void checkOptions(Map<String, String> options)
throws OptionRequiredExce
String feNodes = options.get(DorisOptions.DORIS_FENODES.getName());
if (feNodes.isEmpty()) {
throw new IllegalArgumentException("option [" +
DorisOptions.DORIS_FENODES.getName() + "] is empty");
- } else if (!feNodes.contains(":")) {
- throw new IllegalArgumentException("option [" +
DorisOptions.DORIS_FENODES.getName() + "] is not in correct format, for
example: host:port[,host2:port]");
+ } else if (feNodes.contains(":")) {
+ if (!feNodes.matches("([\\w-.]+:\\d+,)*([\\w-.]+:\\d+)")) {
Review Comment:
add test case and update this pr for some bugs fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
