This is an automated email from the ASF dual-hosted git repository.

gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 93084017974 [opt](s3client) Set ClientConfiguration.requestTimeoutMs 
default value from 3000ms to 30000ms (#49315)
93084017974 is described below

commit 93084017974b27ecd454a5f63f3ab59105cd9f6e
Author: Lei Zhang <zhang...@selectdb.com>
AuthorDate: Sat Mar 22 15:39:14 2025 +0800

    [opt](s3client) Set ClientConfiguration.requestTimeoutMs default value from 
3000ms to 30000ms (#49315)
    
    * ClientConfiguration.requestTimeoutMs default is 3000ms in
    `aws-sdk-cpp`, this should be more than adequate for most services.
    However, we meet problem when cloud provider's storage service or
    network not stable
    
    * refer to
    
https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h
---
 be/src/util/s3_util.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/be/src/util/s3_util.cpp b/be/src/util/s3_util.cpp
index ec328caa337..73b5b65a20d 100644
--- a/be/src/util/s3_util.cpp
+++ b/be/src/util/s3_util.cpp
@@ -297,9 +297,11 @@ std::shared_ptr<io::ObjStorageClient> 
S3ClientFactory::_create_s3_client(
 #endif
     }
 
+    aws_config.requestTimeoutMs = 30000;
     if (s3_conf.request_timeout_ms > 0) {
         aws_config.requestTimeoutMs = s3_conf.request_timeout_ms;
     }
+
     if (s3_conf.connect_timeout_ms > 0) {
         aws_config.connectTimeoutMs = s3_conf.connect_timeout_ms;
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to