gavinchou commented on code in PR #49336:
URL: https://github.com/apache/doris/pull/49336#discussion_r2006891992
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -1889,7 +1889,9 @@ void BlockFileCache::run_background_evict_in_advance() {
batch = config::file_cache_evict_in_advance_batch_bytes;
// Skip if eviction not needed or too many pending recycles
- if (!_need_evict_cache_in_advance || _recycle_keys.size_approx() >=
(batch * 10)) {
+ if (!_need_evict_cache_in_advance ||
+ _recycle_keys.size_approx() >=
Review Comment:
is it coverted by UT? it seems not or the case is not sufficient, we need to
cover it with UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
