This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 410823f4027 [Chore](runtime-filter) remove wrong check and set disable
when SyncSizeClosure meet eof status (#49185)
410823f4027 is described below
commit 410823f4027bde82cb6477349e9cf9650652e774
Author: Pxl <[email protected]>
AuthorDate: Tue Mar 18 14:16:05 2025 +0800
[Chore](runtime-filter) remove wrong check and set disable when
SyncSizeClosure meet eof status (#49185)
### What problem does this PR solve?
remove wrong check and set disable when SyncSizeClosure meet eof status
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [x] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/exprs/runtime_filter.cpp | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/be/src/exprs/runtime_filter.cpp b/be/src/exprs/runtime_filter.cpp
index d4ffb0bacd3..ca5fb3172da 100644
--- a/be/src/exprs/runtime_filter.cpp
+++ b/be/src/exprs/runtime_filter.cpp
@@ -391,9 +391,6 @@ public:
BloomFilterFuncBase* get_bloomfilter() const { return
_context->bloom_filter_func.get(); }
void insert_fixed_len(const vectorized::ColumnPtr& column, size_t start) {
- if (is_ignored()) {
- throw Exception(ErrorCode::INTERNAL_ERROR, "insert_fixed_len meet
ignored rf");
- }
switch (_filter_type) {
case RuntimeFilterType::IN_FILTER: {
_context->hybrid_set->insert_fixed_len(column, start);
@@ -1106,7 +1103,7 @@ class SyncSizeClosure : public
AutoReleaseClosure<PSendFilterSizeRequest,
if (status.is<ErrorCode::END_OF_FILE>()) {
// rf merger backend may finished before rf's send_filter_size, we
just ignore filter in this case.
- ctx->ignored = true;
+ ctx->disabled = true;
} else {
ctx->err_msg = status.to_string();
Base::_process_if_meet_error_status(status);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
