BiteTheDDDDt commented on code in PR #10700: URL: https://github.com/apache/doris/pull/10700#discussion_r916847546
########## be/src/vec/columns/column_nullable.cpp: ########## @@ -134,6 +134,24 @@ const char* ColumnNullable::deserialize_and_insert_from_arena(const char* pos) { return pos; } +size_t ColumnNullable::get_max_row_byte_size() const { + constexpr auto flag_size = sizeof(get_null_map_data()[0]); Review Comment: Maybe we can just use NullMap::T -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org