gavinchou commented on code in PR #49050:
URL: https://github.com/apache/doris/pull/49050#discussion_r1993718279
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java:
##########
@@ -542,9 +542,6 @@ private Map<Long, List<Tablet>>
warmUpNewClusterByTable(long jobId, String dstCl
List<Partition> warmUpPartitions = new ArrayList<>();
for (Partition partition : partitions) {
Long partitionSize = partition.getDataSize(true);
- if ((warmUpTotalFileCache + partitionSize) > totalFileCache) {
Review Comment:
we should move this check after line 549 instead removing them
because it may iterate over all partitions of the table which may exceed too
much of the totalFileCache
it will do useless work just flushing the file cache on BE over and over
again.
and also add efficient logs for this statement , say what table is to
warmup, what is the job content and whether it is a force warmup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
