morrySnow commented on code in PR #10659:
URL: https://github.com/apache/doris/pull/10659#discussion_r916506034
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/plans/logical/LogicalAggregate.java:
##########
@@ -127,14 +129,19 @@ public boolean equals(Object o) {
return false;
}
LogicalAggregate that = (LogicalAggregate) o;
- return Objects.equals(groupByExprList, that.groupByExprList)
+ return Objects.equals(groupByExpressionList,
that.groupByExpressionList)
&& Objects.equals(outputExpressionList,
that.outputExpressionList)
&& Objects.equals(partitionExprList, that.partitionExprList)
&& aggPhase == that.aggPhase;
}
@Override
public int hashCode() {
- return Objects.hash(groupByExprList, outputExpressionList,
partitionExprList, aggPhase);
+ return Objects.hash(groupByExpressionList, outputExpressionList,
partitionExprList, aggPhase);
+ }
+
+ public LogicalAggregate withGroupByAndOutput(List<Expression>
groupByExprList,
Review Comment:
constructor set `disassembled` and `aggPhase` to default value. This
function reserve them current value. But found i bug that, partition expression
set to default value by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
