morrySnow commented on code in PR #48804:
URL: https://github.com/apache/doris/pull/48804#discussion_r1992840637


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java:
##########
@@ -335,6 +335,9 @@ public Boolean 
visitPhysicalNestedLoopJoin(PhysicalNestedLoopJoin<? extends Plan
 
     @Override
     public Boolean visitPhysicalProject(PhysicalProject<? extends Plan> 
project, PushDownContext ctx) {
+        if 
(!project.getOutputSet().containsAll(ctx.probeExpr.getInputSlots())) {

Review Comment:
   only change project is enough? maybe should check all node's output?
   ```
   join(want to generate RF on #[1])
   .
   .
   .
   |-- Semi Join(include ori #[1])
   |   |-- Scan1
   |   +-- Scan2(include ori #[1])
   +-- Project(include real #[1](null as alias#[1]))
       +-- Scan3
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to