zhengshiJ commented on code in PR #10678:
URL: https://github.com/apache/doris/pull/10678#discussion_r916452432
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SortInfo.java:
##########
@@ -63,6 +63,7 @@ public class SortInfo {
// sortTupleDesc_.
private List<Expr> sortTupleSlotExprs;
+
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -255,7 +279,24 @@ public PlanFragment
visitPhysicalSort(PhysicalUnaryPlan<PhysicalHeapSort, Plan>
return mergeFragment;
}
- // TODO: 1. support shuffle join / co-locate / bucket shuffle join later
+ /**
+ * Populate the SortTupleSlotExprs member.
+ */
+ private void createSortTupleSlotExprs(SortInfo info,
+ TupleDescriptor tupleDescriptor,
+ List<Expr> outputList, List<Expr> orderingExpr) {
+ List<Expr> sortTupleSlotExprs = new ArrayList<>();
+ Set<ExprId> exprIds = new HashSet<>();
+ outputList.addAll(orderingExpr);
+ for (Expr expr : outputList) {
+ if (!exprIds.contains(expr)) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
