morningman commented on code in PR #48866:
URL: https://github.com/apache/doris/pull/48866#discussion_r1991776701
##########
be/src/olap/delta_writer.h:
##########
@@ -144,7 +144,9 @@ class DeltaWriter final : public BaseDeltaWriter {
private:
void _init_profile(RuntimeProfile* profile) override;
- void _request_slave_tablet_pull_rowset(const PNodeInfo& node_info);
+ int64_t safe_get_filesize(const std::string& file_path);
Review Comment:
```suggestion
int64_t _safe_get_filesize(const std::string& file_path);
```
##########
be/src/olap/delta_writer.cpp:
##########
@@ -231,7 +231,26 @@ int64_t BaseDeltaWriter::mem_consumption(MemType mem) {
return _memtable_writer->mem_consumption(mem);
}
-void DeltaWriter::_request_slave_tablet_pull_rowset(const PNodeInfo&
node_info) {
+Status safe_get_file_size(const std::string& file_path, int64_t* file_size) {
+ if (file_size == nullptr) {
+ return Status::InvalidArgument("Null output parameter in
safe_get_file_size");
Review Comment:
I think you can just use `CHECK(file_size != nullptr) << "Null output
parameter in safe_get_file_size"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
