yiguolei commented on code in PR #47096:
URL: https://github.com/apache/doris/pull/47096#discussion_r1991222913
##########
be/src/olap/rowset/segment_v2/column_reader.h:
##########
@@ -134,10 +134,10 @@ class ColumnReader : public MetadataAdder<ColumnReader> {
virtual ~ColumnReader();
// create a new column iterator. Client should delete returned iterator
- Status new_iterator(ColumnIterator** iterator);
- Status new_array_iterator(ColumnIterator** iterator);
- Status new_struct_iterator(ColumnIterator** iterator);
- Status new_map_iterator(ColumnIterator** iterator);
+ Status new_iterator(ColumnIterator** iterator, const TabletColumn*
tablet_column);
Review Comment:
Status new_iterator(ColumnIterator** iterator, const TabletColumn*
tablet_column);
new_default_iterator(const TabletColumn& tablet_column,
std::unique_ptr<ColumnIterator>*
iter);
这种参数的顺序最好都一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
