Jibing-Li commented on code in PR #48763:
URL: https://github.com/apache/doris/pull/48763#discussion_r1988575882
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java:
##########
@@ -217,7 +217,7 @@ private static String constructId(Object... params) {
public static void dropStatistics(
long ctlId, long dbId, long tblId, Set<String> colNames,
Set<String> partNames) throws DdlException {
- if (colNames == null && partNames == null) {
+ if ((colNames == null || colNames.isEmpty()) && partNames == null) {
Review Comment:
I think it's better to check empty partNames as well:
```
if (
(colNames == null || colNames.isEmpty())
&&
(partNames == null || partNames.isEmpty())
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
