This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new eff7875a263 branch-3.0: [enhance](mtmv)mv_infos not hold read lock of
tables #47415 (#48674)
eff7875a263 is described below
commit eff7875a2632e8ff77924ec90585fe531e967c43
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Mon Mar 10 17:30:54 2025 +0800
branch-3.0: [enhance](mtmv)mv_infos not hold read lock of tables #47415
(#48674)
Cherry-picked from #47415
Co-authored-by: zhangdong <zhangd...@selectdb.com>
---
.../doris/tablefunction/MetadataGenerator.java | 26 +++-------------------
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java
b/fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java
index b96ec3ef9b9..e6d479105fa 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java
@@ -43,7 +43,6 @@ import org.apache.doris.common.Pair;
import org.apache.doris.common.UserException;
import org.apache.doris.common.proc.FrontendsProcNode;
import org.apache.doris.common.proc.PartitionsProcDir;
-import org.apache.doris.common.util.MetaLockUtils;
import org.apache.doris.common.util.NetUtils;
import org.apache.doris.common.util.TimeUtils;
import org.apache.doris.common.util.Util;
@@ -63,10 +62,8 @@ import
org.apache.doris.datasource.maxcompute.MaxComputeExternalCatalog;
import org.apache.doris.job.common.JobType;
import org.apache.doris.job.extensions.mtmv.MTMVJob;
import org.apache.doris.job.task.AbstractTask;
-import org.apache.doris.mtmv.BaseTableInfo;
import org.apache.doris.mtmv.MTMVPartitionUtil;
import org.apache.doris.mtmv.MTMVStatus;
-import org.apache.doris.mtmv.MTMVUtil;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.plsql.metastore.PlsqlManager;
import org.apache.doris.plsql.metastore.PlsqlProcedureKey;
@@ -115,7 +112,6 @@ import java.time.Instant;
import java.time.LocalDateTime;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Comparator;
import java.util.Date;
import java.util.List;
import java.util.Map;
@@ -851,25 +847,9 @@ public class MetadataGenerator {
if (LOG.isDebugEnabled()) {
LOG.debug("mv: {}", mv.toInfoString());
}
- List<TableIf> needLocked = Lists.newArrayList();
- needLocked.add(mv);
- boolean alwaysNotSync = false;
- try {
- for (BaseTableInfo baseTableInfo :
mv.getRelation().getBaseTables()) {
- TableIf baseTable = MTMVUtil.getTable(baseTableInfo);
- needLocked.add(baseTable);
- }
- } catch (Exception e) {
- alwaysNotSync = true;
- }
- needLocked.sort(Comparator.comparing(TableIf::getId));
- MetaLockUtils.readLockTables(needLocked);
- boolean isSync;
- try {
- isSync = !alwaysNotSync &&
MTMVPartitionUtil.isMTMVSync(mv);
- } finally {
- MetaLockUtils.readUnlockTables(needLocked);
- }
+
+ boolean isSync = MTMVPartitionUtil.isMTMVSync(mv);
+
MTMVStatus mtmvStatus = mv.getStatus();
TRow trow = new TRow();
trow.addToColumnValue(new TCell().setLongVal(mv.getId()));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
